fix(cli): resolve plugins relative to the package context #5794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Not sure how to deal with the failing tests, @sodatea could I get some assistance please? |
merceyz
force-pushed
the
merceyz/resolve
branch
from
2d56c19 to
a417db3
Compare
merceyz
force-pushed
the
merceyz/resolve
branch
from
a417db3 to
0891f05
Compare
merceyz
changed the title
merceyz
force-pushed
the
merceyz/resolve
branch
from
0891f05 to
16e4296
Compare
merceyz
force-pushed
the
merceyz/resolve
branch
from
a13c90f to
54c15ea
Compare
|
Tests finally pass 🎉 |
fangbinwei
reviewed
Dec 8, 2020
merceyz
force-pushed
the
merceyz/resolve
branch
2 times, most recently
from
ac925ca to
21dc7e8
Compare
This reverts commit 3a0caa6.
merceyz
force-pushed
the
merceyz/resolve
branch
from
21dc7e8 to
c5bdb2b
Compare
|
@sodatea Is there a chance this could be backported to v4? |
|
Happy to work in the backport, if we are willing to accept it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vue/cli-serviceis trying to resolve plugins on behalf of itself instead of thepkgContextwhich makes it rely on hoisting to bring it to an accessible location which is not guaranteed, especially in monoreposhttps://yarnpkg.com/advanced/rulebook#packages-should-only-ever-require-what-they-formally-list-in-their-dependencies
Ref yarnpkg/berry#964
Ref #5135
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)